If there is no syncfilehash header, this object didn't come from s3-sync #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the first place. It should be treated as "changed", because there is no way to tell whether it's really changed. "etag" doesn't match "details.md5" because details.md5 encodes some header and other information.
Boolean algebra is, apparenly, not my strongest suit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to handle issue #13.
When I'm sloppy/rushed, I sometimes tweak "just one file, what could it hurt?" with something like s3cmd. When I do that, s3-sync loses track of the file's MD5, but does so in a way that makes it just act like there is no change, ever.
Since
x-amz-meta-syncfilehashis a custom header, its absence means this file wasn't PUT originally using s3-sync, and there's really no way to compare it, reasonably. Maybe one could fall back to etag and comparing md5 of the file, butdetails.md5isn't just for the file, so that's not so good.