Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪪 Adds a more fine-grained profiling context #2975

Merged
merged 7 commits into from
Feb 27, 2025
Merged

🪪 Adds a more fine-grained profiling context #2975

merged 7 commits into from
Feb 27, 2025

Conversation

edbeeching
Copy link
Collaborator

What does this PR do?

  • Adds a more fine-grained profiling context
  • Adds profiling contexts around vllm.generate and each reward function

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

edbeeching and others added 3 commits February 27, 2025 12:41
@edbeeching
fix reward func name
3ebbaea
@edbeeching
add reward to RM name
e86c992
@edbeeching @qgallouedec
Update trl/extras/profiling.py
edcb621 
Co-authored-by: Quentin Gallouédec <45557362+qgallouedec@users.noreply.github.com>
qgallouedec
qgallouedec approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful!

@qgallouedec qgallouedec changed the title Adds a more fine-grained profiling context 🪪 Adds a more fine-grained profiling context Feb 27, 2025
@edbeeching edbeeching merged commit ac327d5 into main Feb 27, 2025
14 checks passed
@edbeeching edbeeching deleted the profiling-context branch February 27, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qgallouedec qgallouedec qgallouedec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edbeeching @HuggingFaceDocBuilderDev @qgallouedec