Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy import libraries in src/transformers/image_utils.py #36435

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Feb 26, 2025

Lazy import the imports added by #34275.

Enables vllm-project/vllm#13905 (which strictly enforces that cv2 is lazily imported).

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me since we use it only to load videos, and we're planning to separate away these fn to a new video_utils file

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep thanks for protecting with requires backend! 🤗

@hmellor hmellor merged commit 6a87646 into huggingface:main Feb 27, 2025
23 checks passed
@hmellor hmellor deleted the lazy-import-image-utils branch February 27, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants