-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qwen2VL fix cos,sin dtypes to float when used with deepspeed #36188
Conversation
Must have been fixed by #36065? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we can probably do this in apply_rotary_pos_emb_flashatt
and apply_rotary_pos_emb_vision
to cover both cases! (.float done in if and in else) !
Yep let's merge this (need to fix the modular fix not the modeling file! 🤗 ) |
Hey, let's merge this and have in the next patch release (dunno when that will be). Seems to be bothering more people as we wait @ArdalanM can you please add the same changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! ❤️
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
What does this PR do?
Minor fix for Qwen2VL models where the sin and cos position embeddings where wrongly casted when used with DeepSpeed. Related issue (#36187)
cc @ArthurZucker 🤗
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.