[Modular] skip modular checks based on diff #36130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
commented
Feb 11, 2025
| @@ -1024,40 +1024,6 @@ def _rep(match): | |||
| return readmes_match, "\n".join((x[1] for x in sorted_index)) + "\n" | |||
|
|
|||
|
|
|||
| def _find_text_in_file(filename: str, start_prompt: str, end_prompt: str) -> Tuple[str, int, int, List[str]]: | |||
There was a problem hiding this comment.
(was checking code on this file, noticed this fn was unused)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
✨ Faster modular checks on most PRs ✨
It takes advantage of having the modular checks being done in topological order. The loop over files in topological order was modified to:
In branches with zero model changes, it shaves off ~1min [on my machine]. With one modular leaf model change, it shaves off ~55 secs. 🤗