Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paligemma: revert #36084 #36113

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Paligemma: revert #36084 #36113

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b98bf32
revert
zucchini-nlp Feb 10, 2025
b81d18c
type check
zucchini-nlp Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/transformers/models/paligemma/processing_paligemma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from typing import List, Optional, Union

from ...feature_extraction_utils import BatchFeature
from ...image_utils import ImageInput, is_valid_image, make_flat_list_of_images, make_nested_list_of_images
from ...image_utils import ImageInput, is_valid_image, make_flat_list_of_images
from ...processing_utils import (
ImagesKwargs,
ProcessingKwargs,
Expand Down Expand Up @@ -256,7 +256,13 @@ def __call__(
)

# make a nested list of lists to be able to iterate over the images and text below
images = make_nested_list_of_images(images)
if is_valid_image(images):
images = [[images]]
elif isinstance(images, list) and is_valid_image(images[0]):
images = [[image] for image in images]
elif not (isinstance(images, list) and isinstance(images[0], list) and is_valid_image(images[0][0])):
raise ValueError("images must be an image, list of images or list of list of images")

input_strings = [
build_string_from_input(
prompt=prompt,
Expand Down
Loading