docs: fix return type annotation of get_default_model_revision

[MarcoGorelli]

What does this PR do?

Fixes #35981

Before submitting

• This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
• Did you read the contributor guideline,
  Pull Request section?
• Was this discussed/approved via a Github issue or the forum? Please add a link
  to it if that's the case.
• Did you make sure to update the documentation with your changes? Here are the
  documentation guidelines, and
  here are tips on formatting docstrings.
• Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

[Rocketknight1]

Yes, this looks good! Rebased the PR and enabled doctests

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[Rocketknight1]

Hi @MarcoGorelli, the rebase fixed most issues but the failing TF test looks related - maybe the assumption that the return value is always Tuple[str, str] is not true in some TF cases?

[MarcoGorelli]

thanks @Rocketknight1 for your review!

the traceback shows

>       with open(vocab_file, encoding="utf-8") as vocab_handle:
E       TypeError: expected str, bytes or os.PathLike object, not NoneType

and I wouldn't have expected the type annotation to influence that. Taking a look anyway

Any chance you could help me with running the test please? I tried running

RUN_PIPELINE_TESTS=1 pytest tests/models/whisper/test_modeling_tf_whisper.py::TFWhisperModelTest::test_pipeline_feature_extraction

but it still gets skipped

[Rocketknight1]

Hi @MarcoGorelli, tests are passing now! Were the failures earlier just a coincidence that were solved with a rebase?

[MarcoGorelli]

Awesome! I think so

[Rocketknight1]

LGTM, in that case! cc @ArthurZucker @Cyrilvallez for core maintainer review

[ArthurZucker]

Thanks!