Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix MllamaVisionAttention typehint #35975

Merged

Conversation

kylesayrs
Copy link
Contributor

What does this PR do?

  • Fix type hint in MllamaVisionAttention.forward

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it, let's mark it also optional as it can be None

@zucchini-nlp
Copy link
Member

zucchini-nlp commented Feb 5, 2025

@kylesayrs can you run make fix-copies to make CI happy?

Edit: rebasing should solve it now

kylesayrs and others added 3 commits February 8, 2025 17:13
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Co-authored-by: Raushan Turganbay <raushan.turganbay@alumni.nu.edu.kz>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@kylesayrs kylesayrs force-pushed the redhat/MllamaVisionAttention-typehint branch from 33dcfd1 to 100dad2 Compare February 8, 2025 22:14
@kylesayrs
Copy link
Contributor Author

@zucchini-nlp Sorry for the delay here, thanks for your help

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zucchini-nlp zucchini-nlp merged commit 3a3b06a into huggingface:main Feb 10, 2025
10 checks passed
sbucaille pushed a commit to sbucaille/transformers that referenced this pull request Feb 16, 2025
* fix MllamaVisionAttention typehint

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>

* Update src/transformers/models/mllama/modeling_mllama.py

Co-authored-by: Raushan Turganbay <raushan.turganbay@alumni.nu.edu.kz>

* fix suggestion

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>

---------

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Co-authored-by: Raushan Turganbay <raushan.turganbay@alumni.nu.edu.kz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants