-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix MllamaVisionAttention typehint #35975
fix MllamaVisionAttention typehint #35975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it, let's mark it also optional as it can be None
@kylesayrs can you run Edit: rebasing should solve it now |
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Co-authored-by: Raushan Turganbay <raushan.turganbay@alumni.nu.edu.kz>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
33dcfd1
to
100dad2
Compare
@zucchini-nlp Sorry for the delay here, thanks for your help |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* fix MllamaVisionAttention typehint Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> * Update src/transformers/models/mllama/modeling_mllama.py Co-authored-by: Raushan Turganbay <raushan.turganbay@alumni.nu.edu.kz> * fix suggestion Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> --------- Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> Co-authored-by: Raushan Turganbay <raushan.turganbay@alumni.nu.edu.kz>
What does this PR do?
MllamaVisionAttention.forward