Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated update_repo_visibility #35970

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Jan 30, 2025

update_repo_visibility has been deprecated for a more generic update_repo_settings and will be removed in a future version. This PR replaces it in a test. I bumped huggingface_hub lowest version to 0.26 to be sure it's installed. Latest huggingface_hub version is 0.28.

Related to huggingface/huggingface_hub#2502

@Wauplin Wauplin requested a review from a team January 30, 2025 13:36
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin
Copy link
Contributor Author

Wauplin commented Jan 30, 2025

Lots of failing tests but I hardly see how it can be related to my PR 😬

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hub might have been down! can you just rebase to rerun tests?

@Wauplin
Copy link
Contributor Author

Wauplin commented Feb 12, 2025

@ArthurZucker I'm still getting an error but doesn't seem related to this PR:

FAILED tests/utils/test_import_utils.py::test_clear_import_cache - AssertionError: assert 'transformers.models.auto.modeling_auto' in {'PIL': <module 'PIL' from '/usr/local/lib/python3.9/site-packages/PIL/__init__.py'>, 'PIL.BmpImagePlugin': <module 'PIL.BmpImagePlugin' from '/usr/local/lib/python3.9/site-packages/PIL/BmpImagePlugin.py'>, 'PIL.ExifTags': <module 'PIL.ExifTags' from '/usr/local/lib/python3.9/site-packages/PIL/ExifTags.py'>, 'PIL.GifImagePlugin': <module 'PIL.GifImagePlugin' from '/usr/local/lib/python3.9/site-packages/PIL/GifImagePlugin.py'>, ...}
 +  where {'PIL': <module 'PIL' from '/usr/local/lib/python3.9/site-packages/PIL/__init__.py'>, 'PIL.BmpImagePlugin': <module 'PIL.BmpImagePlugin' from '/usr/local/lib/python3.9/site-packages/PIL/BmpImagePlugin.py'>, 'PIL.ExifTags': <module 'PIL.ExifTags' from '/usr/local/lib/python3.9/site-packages/PIL/ExifTags.py'>, 'PIL.GifImagePlugin': <module 'PIL.GifImagePlugin' from '/usr/local/lib/python3.9/site-packages/PIL/GifImagePlugin.py'>, ...} = sys.modules

Ok to merge ?

@ArthurZucker ArthurZucker merged commit e60ae0d into main Feb 13, 2025
24 of 26 checks passed
@ArthurZucker ArthurZucker deleted the dont-use-deprecated-method branch February 13, 2025 10:27
@ArthurZucker
Copy link
Collaborator

Yep! unrelated to your pr!

eleanorTurintech pushed a commit to eleanorTurintech/transformers that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants