Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doctest] Fixes #35863

Merged
merged 1 commit into from
Jan 26, 2025
Merged

[doctest] Fixes #35863

merged 1 commit into from
Jan 26, 2025

Conversation

stevhliu
Copy link
Member

Attempts to fix some of the failing doctests 😅

Some of the ones I couldn't figure out:

  • CodeLlama is gated and the doctest job can't access it?
  • Moshi, not sure what the waveform_to_token_ratio value should be
  • SigLIP, FlashAttention2 is not installed so attn_implementation="flash_attention_2" is causing it to fail
  • generation_strategies.md, the facebook/layerskip-llama3.2-1B checkpoint is also gated and can't be accessed
  • pipeline_tutorial.md and quicktour.md, out-of-memory on the tests?
  • task_summary.md, not sure how to resolve RuntimeError('CuDNN error: CUDNN_STATUS_INTERNAL_ERROR')

@stevhliu stevhliu requested a review from ArthurZucker January 23, 2025 23:11
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of the changes are caused to updating the default NB of toekns generated to 20 + length of input!

@stevhliu stevhliu merged commit f11f57c into huggingface:main Jan 26, 2025
10 checks passed
@stevhliu stevhliu deleted the fixes branch January 26, 2025 23:26
bursteratom pushed a commit to bursteratom/transformers that referenced this pull request Jan 31, 2025
elvircrn pushed a commit to elvircrn/transformers that referenced this pull request Feb 13, 2025
sbucaille pushed a commit to sbucaille/transformers that referenced this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants