Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another security patch for self-comment-ci.yml #35816

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jan 21, 2025

What does this PR do?

For the jobs go after get-sha which will checkout to refs/pull/$PR_NUMBER/merge, we need to check the checked out commit sha (which we don't know if it is safe) is the same as the (already verified) one given by ${{ needs.get-sha.outputs.PR_MERGE_SHA }}.

@ydshieh ydshieh requested a review from glegendre01 January 21, 2025 14:12
Copy link
Contributor

@glegendre01 glegendre01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ydshieh ydshieh merged commit 870e2c8 into main Jan 22, 2025
11 checks passed
@ydshieh ydshieh deleted the even_more_secure branch January 22, 2025 08:29
bursteratom pushed a commit to bursteratom/transformers that referenced this pull request Jan 31, 2025
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
elvircrn pushed a commit to elvircrn/transformers that referenced this pull request Feb 13, 2025
fix

Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants