Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyTorch version check for FA backend on AMD GPUs #35813

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

mht-sharma
Copy link
Contributor

What does this PR do?

Updates condition from PR #30850

Garbage values may occur during model generation with models like LLama, Mistral, and Mixtral, particularly when utilizing multi-gpu setup and device_map=auto alongside SDPA and FA.

The above issue is fixed in the newer PyTorch versions.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@mht-sharma mht-sharma requested a review from SunMarc January 21, 2025 10:55
@Rocketknight1
Copy link
Member

cc @SunMarc @MekkCyber @muellerzr

@MekkCyber
Copy link
Contributor

Good catch ! LGTM, thanks for the fix !

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG

@SunMarc SunMarc merged commit fdcc62c into huggingface:main Jan 22, 2025
25 checks passed
bursteratom pushed a commit to bursteratom/transformers that referenced this pull request Jan 31, 2025
Disable FA backend for SDPA on AMD GPUs (PyTorch < 2.4.1)
elvircrn pushed a commit to elvircrn/transformers that referenced this pull request Feb 13, 2025
Disable FA backend for SDPA on AMD GPUs (PyTorch < 2.4.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants