Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipeline] missing import regarding assisted generation #35752

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

gante
Copy link
Member

@gante gante commented Jan 17, 2025

What does this PR do?

Noticed while working on #34639

#34504 introduced an import error that was not caught in CI (and we had fast tests for the related flag, which were failing). This PR fixes it.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It's annoying the CI missed this.

@gante gante merged commit ec28957 into huggingface:main Jan 22, 2025
25 checks passed
@gante gante deleted the pipeline_missing_import branch January 22, 2025 10:34
bursteratom pushed a commit to bursteratom/transformers that referenced this pull request Jan 31, 2025
elvircrn pushed a commit to elvircrn/transformers that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants