Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Falcon tie_word_embeddings in GGUF #35715

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Fix: Falcon tie_word_embeddings in GGUF #35715

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
757765c
fix falcon tie_word_embeddings
MekkCyber Jan 15, 2025
2c59f0b
fix style
MekkCyber Jan 15, 2025
8c313a0
Merge branch 'main' into fix_ggml_falcon_tiewordembeddings
MekkCyber Jan 15, 2025
17fec72
Merge branch 'main' into fix_ggml_falcon_tiewordembeddings
MekkCyber Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/transformers/modeling_gguf_pytorch_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,9 @@ def load_gguf_checkpoint(gguf_checkpoint_path, return_tensors=False, model_to_lo

# Handle tie_word_embeddings, if lm_head.weight is not present in tensors,
# tie_word_embeddings is true otherwise false
parsed_parameters["config"]["tie_word_embeddings"] = all(
"output.weight" != tensor.name for tensor in reader.tensors
exceptions = ["falcon"]
parsed_parameters["config"]["tie_word_embeddings"] = (
all("output.weight" != tensor.name for tensor in reader.tensors) or architecture in exceptions
)

# List all key-value pairs in a columnized format
Expand Down
Loading