Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether rescale is requested before checking is_scaled_image #35439

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

squidpickles
Copy link
Contributor

What does this PR do?

This change checks whether do_rescale is enabled in image processors before checking is_scaled_image().

is_scaled_image() needs to scan every element to get the min and max values, to determine whether they are between 0 and 1. If do_rescale is False, this is an unnecessary check.

This change swaps the order of the check, so it first checks do_rescale and then is_scaled_image(). Just a minor performance improvement on some image processing.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts, @qubvel

Copy link
Member

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @squidpickles! Great catch, thanks for updating it throughout the repo.

@qubvel qubvel merged commit 665a494 into huggingface:main Jan 7, 2025
23 checks passed
AlanPonnachan pushed a commit to AlanPonnachan/transformers that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants