Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove benchmark job in push-important-models.yml #35292

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Dec 16, 2024

What does this PR do?

As discussed offline: the benchmark workflow is updated and is triggered directly with push to main / pull_request events.
There is no need to be called in .github/workflows/push-important-models.yml (and it's currently failing due to the format mismatching)

@ydshieh ydshieh changed the title remove-bench remove benchmark job in push-important-models.yml Dec 16, 2024
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep sounds good we'll have the tag and comment anyways

@ydshieh ydshieh merged commit d29a06e into main Dec 17, 2024
11 checks passed
@ydshieh ydshieh deleted the remove-bench branch December 17, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants