PaliGemma: Make sure to add <eos> to suffix if <image> is present in text
#35201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally with reproducer from #35200 and it fixes the issue |
molbap
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
LGTM - thanks for the fix! cc @ArthurZucker for merge
Issue was already present for PaliGemma1
|
Let me know if there's anything else I can do to help get this merged |
ArthurZucker
approved these changes
Dec 19, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Solves: #35200
Makes sure to add the
<eos>token to thesuffixin either case (<image>is present intextor not). This avoids gotchas when finetuning.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @molbap