Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n-<languageCode>] Translating Benchmarks.md to Chinese #35137

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

asdkfjsd
Copy link
Contributor

@asdkfjsd asdkfjsd commented Dec 7, 2024

What does this PR do?

I have translated Benchmarks.md to Chinese. Please let me know if there are any corrections. Thank you very much!
According to the context, I translated 'Benchmark best practices' as 'Recommended Strategies for Benchmarking' in Chinese .

issue: [i18n-] Translating Benchmarks.md to Chinese #35134
Fixes # https://github.com/huggingface/transformers/issues/35134

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Member

cc @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation. Overall, I think it looks good, but its just a little difficult to read with both English/Chinese content.

Can you also find another contributor to review the translated content (I can't read Chinese)?

docs/source/zh/benchmarks.md Outdated Show resolved Hide resolved
@asdkfjsd
Copy link
Contributor Author

I have removed all the English original text (which was previously kept as comments in the document) and refined some of the Chinese expressions. Any suggestions or corrections are welcome.

@HMJ0628
Copy link
Contributor

HMJ0628 commented Dec 10, 2024

The translation is good and the meaning is clear.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@stevhliu stevhliu merged commit 91b8ab1 into huggingface:main Dec 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants