-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n-<languageCode>] Translating Benchmarks.md to Chinese #35137
Conversation
cc @stevhliu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation. Overall, I think it looks good, but its just a little difficult to read with both English/Chinese content.
Can you also find another contributor to review the translated content (I can't read Chinese)?
…omments in the document) and refined some of the Chinese expressions.
I have removed all the English original text (which was previously kept as comments in the document) and refined some of the Chinese expressions. Any suggestions or corrections are welcome. |
The translation is good and the meaning is clear. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
What does this PR do?
I have translated Benchmarks.md to Chinese. Please let me know if there are any corrections. Thank you very much!
According to the context, I translated 'Benchmark best practices' as 'Recommended Strategies for Benchmarking' in Chinese .
issue: [i18n-] Translating Benchmarks.md to Chinese #35134
Fixes # https://github.com/huggingface/transformers/issues/35134
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.