Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rsfE with pytest #35119

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Use rsfE with pytest #35119

merged 2 commits into from
Dec 13, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Dec 6, 2024

What does this PR do?

parse_pytest_errors_output (in .circleci/parse_test_outputs.py)

requires rsfE flag in pytest

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@@ -32,7 +32,7 @@
"RUN_PT_FLAX_CROSS_TESTS": False,
}
# Disable the use of {"s": None} as the output is way too long, causing the navigation on CircleCI impractical
COMMON_PYTEST_OPTIONS = {"max-worker-restart": 0, "dist": "loadfile", "vvv": None, "rsf":None}
COMMON_PYTEST_OPTIONS = {"max-worker-restart": 0, "dist": "loadfile", "vvv": None, "rsfE":None}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary to make

parse_pytest_errors_output
(in .circleci/parse_test_outputs.py)

work

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise error won't show in summary section

@ydshieh ydshieh requested a review from ArthurZucker December 6, 2024 10:55
@ydshieh ydshieh marked this pull request as ready for review December 6, 2024 10:55
@ydshieh ydshieh changed the title tiny update Use rsfE with pytest Dec 6, 2024
@ydshieh
Copy link
Collaborator Author

ydshieh commented Dec 13, 2024

merged as approved by Arthur offline

@ydshieh ydshieh merged commit 8096161 into main Dec 13, 2024
25 checks passed
@ydshieh ydshieh deleted the tiny_fix branch December 13, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants