-
Notifications
You must be signed in to change notification settings - Fork 27.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix use_parallel_residual
and qkv_bias
for StableLM GGUF config extraction
#34450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @Isotr0py !
Hey @Isotr0py! These changes are good to me. Thank you! Please, fix test_stablelm_weights_conversion_fp16 and test_stablelm_fp16 in test_ggml.py as well to get rid of config=original_model.config as we do not need it anymore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Can you try to rebase your PR in order to pass the CI @Isotr0py ? |
@SunMarc I have merged the main branch but seems that the test CI is still failing in unrelated tests: |
Hey, try to do rebase. First of all, in command line, |
79a8774
to
3917d3d
Compare
The problematic test should have been fixed by #34605. Can you try to rebase on that ? |
803c278
to
a59795a
Compare
@SunMarc All tests passed now! |
Niceee ! |
…xtraction (huggingface#34450) * fix stablelm qkv_bias * fix stablelm qkv_bias and use_parallel_residual * remove original_model.config for stablelm gguf test
What does this PR do?
Fixes #34426 (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@VladOS95-cyber @SunMarc