Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n-HI] Translated accelerate page to Hindi #34443

Merged
merged 5 commits into from
Nov 1, 2024
Merged

[i18n-HI] Translated accelerate page to Hindi #34443

merged 5 commits into from
Nov 1, 2024

Conversation

karthik-script
Copy link
Contributor

@karthik-script karthik-script commented Oct 27, 2024 •
edited
Loading

What does this PR do?

Translated accelerate page to Hindi and updated the _toctree.yml file

Fixes # (issue) #34441

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

cc: @stevhliu and @MKhalusova

@karthik-script
Copy link
Contributor Author

Upon the successful implementation of this PR, I intend to increase my translation efforts. Thank you for your support.

stevhliu
stevhliu reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your translation!

You'll also need to find someone who can review the translated content since I can't read Hindi! #26787 is a good place to see if other community members are interested :)

@karthik-script karthik-script mentioned this pull request Oct 28, 2024
Open
10 tasks
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@karthik-script karthik-script mentioned this pull request Oct 31, 2024
Merged
6 tasks
kbdharun
kbdharun reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, chiming in from tldr-pages/tldr#14452. As a translator myself, I have a few technical suggestions for this page.

You'll also need to find someone who can review the translated content since I can't read Hindi! #26787 is a good place to see if other community members are interested :)

Hi, I have gone through the page. Overall it looks fine, I have made a few technical suggestions after this the PR should be GTG.

Note

While I can read and understand Hindi, I am not a native speaker so feel free to get a second review if required.

docs/source/hi/accelerate.md Outdated Show resolved Hide resolved
docs/source/hi/accelerate.md Outdated Show resolved Hide resolved
docs/source/hi/accelerate.md Outdated Show resolved Hide resolved
docs/source/hi/accelerate.md Outdated Show resolved Hide resolved
karthik-script and others added 4 commits October 31, 2024 09:25
@karthik-script @kbdharun
Update docs/source/hi/accelerate.md
25b7a8f 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@karthik-script @kbdharun
Update docs/source/hi/accelerate.md
bd47e8e 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@karthik-script @kbdharun
Update docs/source/hi/accelerate.md
4e18708 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@karthik-script @kbdharun
Update docs/source/hi/accelerate.md
2d75bfc 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
kbdharun
kbdharun approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stevhliu
stevhliu approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job and thanks again!

@stevhliu stevhliu merged commit 33868a0 into huggingface:main Nov 1, 2024
9 checks passed
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
@karthik-script @kbdharun @BernardZach
[i18n-HI] Translated accelerate page to Hindi (huggingface#34443)
74c5920 
* [i18n-HI] Translated accelerate page to Hindi

* Update docs/source/hi/accelerate.md

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* Update docs/source/hi/accelerate.md

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* Update docs/source/hi/accelerate.md

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* Update docs/source/hi/accelerate.md

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

---------

Co-authored-by: Kay <kay@Kays-MacBook-Pro.local>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karthik-script @HuggingFaceDocBuilderDev @kbdharun @stevhliu