-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat template: return vectorized output in processors #34275
Merged
zucchini-nlp
merged 42 commits into
huggingface:main
from
zucchini-nlp:chat-template-vlms
Jan 10, 2025
Merged
Changes from 6 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
d66a928
update chat template
zucchini-nlp 2bff795
Merge branch 'main' into chat-template-vlms
zucchini-nlp 3c24aff
style
zucchini-nlp 710edd1
fix tests
zucchini-nlp 1bf58f3
Merge branch 'main' into chat-template-vlms
zucchini-nlp 76d24ae
Merge branch 'main' into chat-template-vlms
zucchini-nlp eb588d1
Update src/transformers/image_utils.py
zucchini-nlp 3de67e0
typehints + docs
zucchini-nlp bcf3dac
fix tests
zucchini-nlp 87205d7
Merge branch 'main' into chat-template-vlms
zucchini-nlp 6282694
remove unnecessary warnings
zucchini-nlp 690c314
forgot code style :(
zucchini-nlp 9049d64
allow users to pass backend and num frames
zucchini-nlp 243b4c3
Update docs/source/en/chat_templating.md
zucchini-nlp 899d20d
Update src/transformers/image_utils.py
zucchini-nlp 47272f8
Update src/transformers/image_utils.py
zucchini-nlp fc8ba58
Update src/transformers/image_utils.py
zucchini-nlp 8b0ddd7
Update src/transformers/image_utils.py
zucchini-nlp d2d27fb
Update src/transformers/image_utils.py
zucchini-nlp 1adfbca
Update src/transformers/image_utils.py
zucchini-nlp d0209e2
Update src/transformers/processing_utils.py
zucchini-nlp cde21be
Merge branch 'main' into chat-template-vlms
zucchini-nlp 34ee690
typo fix
zucchini-nlp 3cd24ac
merge main
zucchini-nlp 91057e4
style
zucchini-nlp 5edb363
address comments
zucchini-nlp 04080ea
Merge branch 'main' into chat-template-vlms
zucchini-nlp eb450f8
Merge branch 'main' into chat-template-vlms
zucchini-nlp 9cc74a4
align with "pipeline" template
zucchini-nlp 39724ef
update docs
zucchini-nlp 72368f7
update docs
zucchini-nlp 376e808
merge main
zucchini-nlp de58cb0
unpack for all kwargs?
zucchini-nlp 71a82b5
wrong conflict resolution while rebasing
zucchini-nlp 4e62720
tmp
zucchini-nlp 45289f3
update docs
zucchini-nlp 503b153
Merge branch 'main' into chat-template-vlms
zucchini-nlp 2b54a52
Update docs/source/en/chat_templating.md
zucchini-nlp 3c3441e
Update docs/source/en/chat_templating.md
zucchini-nlp 4600728
Update docs/source/en/chat_templating.md
zucchini-nlp 39875be
Update docs/source/en/chat_templating.md
zucchini-nlp db2ec0c
Merge branch 'main' into chat-template-vlms
zucchini-nlp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block breaks lazy importing of
cv2
whichvllm
strictly enforces. It happens when vLLM importsfrom transformers.image_utils import ImageInput
. vLLM cannot upgrade to v4.49.0 because of it vllm-project/vllm#13905.Would it be possible to delay this import? This would be preferable to lazily importing
ImageInput
everywhere it's used in vLLM.cc @ArthurZucker