Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat template: return vectorized output in processors #34275
Chat template: return vectorized output in processors #34275
Changes from 12 commits
d66a928
2bff795
3c24aff
710edd1
1bf58f3
76d24ae
eb588d1
3de67e0
bcf3dac
87205d7
6282694
690c314
9049d64
243b4c3
899d20d
47272f8
fc8ba58
8b0ddd7
d2d27fb
1adfbca
d0209e2
cde21be
34ee690
3cd24ac
91057e4
5edb363
04080ea
eb450f8
9cc74a4
39724ef
72368f7
376e808
de58cb0
71a82b5
4e62720
45289f3
503b153
2b54a52
3c3441e
4600728
39875be
db2ec0c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block breaks lazy importing of
cv2
whichvllm
strictly enforces. It happens when vLLM importsfrom transformers.image_utils import ImageInput
. vLLM cannot upgrade to v4.49.0 because of it vllm-project/vllm#13905.Would it be possible to delay this import? This would be preferable to lazily importing
ImageInput
everywhere it's used in vLLM.cc @ArthurZucker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional kwargs might be required here, e.g. timeout, but probably fine for now