Update daily ci to use new cluster #33627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Sep 20, 2024
Comment on lines
+101
to
+116
| - name: Set `machine_type` for report and artifact names | ||
| working-directory: /transformers | ||
| shell: bash | ||
| run: | | ||
| echo "${{ inputs.machine_type }}" | ||
|
|
||
| if [ "${{ inputs.machine_type }}" = "aws-g4dn-2xlarge-cache" ]; then | ||
| machine_type=single-gpu | ||
| elif [ "${{ inputs.machine_type }}" = "aws-g4dn-12xlarge-cache" ]; then | ||
| machine_type=multi-gpu | ||
| else | ||
| machine_type=${{ inputs.machine_type }} | ||
| fi | ||
|
|
||
| echo "$machine_type" | ||
| echo "machine_type=$machine_type" >> $GITHUB_ENV |
There was a problem hiding this comment.
The new cluster is named aws-g4dn-2xlarge-cache or aws-g4dn-12xlarge-cache, but we need single-gpu and/or multi-gpu for the report file name or artifact name.
ydshieh
commented
Sep 20, 2024
Comment on lines
+5
to
+7
| repository_dispatch: | ||
| schedule: | ||
| - cron: "17 2 * * *" |
ydshieh
commented
Sep 20, 2024
| @@ -102,7 +103,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| machine_type: [single-gpu, multi-gpu] | |||
| machine_type: [aws-g4dn-2xlarge-cache, aws-g4dn-12xlarge-cache] | |||
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
approved these changes
Sep 20, 2024
Yes I agree. I will think of it but let's try to run the CI during this weekend and potentially give feedbacks to the infra team on Monday 🙏 Thank you for the review. |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* update * re-enable daily CI --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
And re-enable daily (which was disabled in #33136)
I haven't had a final confirmation from @glegendre01 , but let's take a chance to run it during this weekend.