Fix CircleCI nightly run #33558
Merged
Fix CircleCI nightly run #33558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Sep 18, 2024
Comment on lines
+85
to
+127
| - run: uv pip install -U -e . | ||
| - run: echo 'export "GIT_COMMIT_MESSAGE=$(git show -s --format=%s)"' >> "$BASH_ENV" && source "$BASH_ENV" | ||
| - run: mkdir -p test_preparation | ||
| - run: python utils/tests_fetcher.py --fetch_all | tee tests_fetched_summary.txt | ||
| - run: python utils/tests_fetcher.py --filter_tests | ||
| - run: export "GIT_COMMIT_MESSAGE=$(git show -s --format=%s)" && echo $GIT_COMMIT_MESSAGE && python .circleci/create_circleci_config.py --fetcher_folder test_preparation | ||
| - run: | | ||
| echo -n "tests" > test_list.txt | ||
| python utils/tests_fetcher.py --filter_tests | ||
| mv test_list.txt test_preparation/filtered_test_list.txt | ||
| - run: python .circleci/create_circleci_config.py --fetcher_folder test_preparation | ||
| - run: cp test_preparation/generated_config.yml test_preparation/generated_config.txt | ||
| if [ ! -s test_preparation/generated_config.yml ]; then | ||
| echo "No tests to run, exiting early!" | ||
| circleci-agent step halt | ||
| fi | ||
|
|
||
| - store_artifacts: | ||
| path: test_preparation/generated_config.txt | ||
| path: test_preparation | ||
|
|
||
| - run: | ||
| name: "Retrieve Artifact Paths" | ||
| env: | ||
| CIRCLE_TOKEN: ${{ secrets.CI_ARTIFACT_TOKEN }} | ||
| command: | | ||
| project_slug="gh/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}" | ||
| job_number=${CIRCLE_BUILD_NUM} | ||
| url="https://circleci.com/api/v2/project/${project_slug}/${job_number}/artifacts" | ||
| curl -o test_preparation/artifacts.json ${url} | ||
| - run: | ||
| name: "Prepare pipeline parameters" | ||
| command: | | ||
| python utils/process_test_artifacts.py | ||
|
|
||
| # To avoid too long generated_config.yaml on the continuation orb, we pass the links to the artifacts as parameters. | ||
| # Otherwise the list of tests was just too big. Explicit is good but for that it was a limitation. | ||
| # We used: | ||
|
|
||
| # https://circleci.com/docs/api/v2/index.html#operation/getJobArtifacts : to get the job artifacts | ||
| # We could not pass a nested dict, which is why we create the test_file_... parameters for every single job | ||
|
|
||
| - store_artifacts: | ||
| path: test_preparation/transformed_artifacts.json | ||
| - store_artifacts: | ||
| path: test_preparation/artifacts.json | ||
| - continuation/continue: | ||
| configuration_path: test_preparation/generated_config.yml | ||
| parameters: test_preparation/transformed_artifacts.json | ||
| configuration_path: test_preparation/generated_config.yml |
There was a problem hiding this comment.
Just copied from - fetch_tests with a single difference
run: python utils/tests_fetcher.py | tee tests_fetched_summary.txt
becomes
run: python utils/tests_fetcher.py --fetch_all | tee tests_fetched_summary.txt
ydshieh
commented
Sep 18, 2024
| @@ -1193,9 +1193,9 @@ def create_test_list_from_filter(full_test_list, out_path): | |||
| default=None, | |||
| ) | |||
| parser.add_argument( | |||
| "--commit_message", | |||
There was a problem hiding this comment.
this is never used.
(The actual used one is commit_message = repo.head.commit.message)
ydshieh
commented
Sep 18, 2024
Comment on lines
+1216
to
+1217
| if args.fetch_all: | ||
| commit_flags["test_all"] = True |
There was a problem hiding this comment.
might not be perfect to do this, but it's a minimal change to make it work
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Sep 19, 2024
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently on
main, it always givesemptyas jobs.