Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] enable GemmaIntegrationTest on XPU #33555

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Sep 18, 2024

What does this PR do?

Below are the test results on XPU. There are some tests failed, because the generated text don't exactly match the expected tests due to precision issues. We will take a look into it, but I think GemmaIntegrationTest should also run on non-cuda devices.

================================================= short test summary info =================================================
PASSED tests/models/gemma/test_modeling_gemma.py::GemmaIntegrationTest::test_model_2b_bf16
PASSED tests/models/gemma/test_modeling_gemma.py::GemmaIntegrationTest::test_model_2b_fp16
PASSED tests/models/gemma/test_modeling_gemma.py::GemmaIntegrationTest::test_model_2b_sdpa
SKIPPED [1] tests/models/gemma/test_modeling_gemma.py:794: test requires CUDA
SKIPPED [1] tests/models/gemma/test_modeling_gemma.py:655: test requires bitsandbytes and torch
SKIPPED [1] tests/models/gemma/test_modeling_gemma.py:632: test requires Flash Attention
SKIPPED [1] tests/models/gemma/test_modeling_gemma.py:776: test requires bitsandbytes and torch
SKIPPED [1] tests/models/gemma/test_modeling_gemma.py:674: The test will not fit our CI runners
FAILED tests/models/gemma/test_modeling_gemma.py::GemmaIntegrationTest::test_model_2b_bf16_dola - AssertionError: Lists differ: ['Hel[64 chars] The only tool we have is a scale', 'Hi today [58 chars] of'] != ['Hel[64...
FAILED tests/models/gemma/test_modeling_gemma.py::GemmaIntegrationTest::test_model_2b_eager - AssertionError: Lists differ: ['Hel[117 chars]ith you a very easy and simple recipe of <strong><em>Kaju Kat'] != ['Hel...
FAILED tests/models/gemma/test_modeling_gemma.py::GemmaIntegrationTest::test_model_7b_bf16 - KeyError: None
FAILED tests/models/gemma/test_modeling_gemma.py::GemmaIntegrationTest::test_model_7b_fp16 - AssertionError: Lists differ: ['Hel[27 chars]a 1995 4.0L 4x4. I', 'Hi today I am going to s[51 chars] 3D'] != ['Hel[27...
FAILED tests/models/gemma/test_modeling_gemma.py::GemmaIntegrationTest::test_model_7b_fp16_static_cache - AssertionError: Lists differ: ['Hel[27 chars]a 1995 4.0L 4x4. I', 'Hi today I am going to s[51 chars] 3D'] != ['Hel[27...
============================= 5 failed, 3 passed, 5 skipped, 2 warnings in 126.64s (0:02:06) ==============================

@faaany
Copy link
Contributor Author

faaany commented Sep 18, 2024

@amyeroberts

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts amyeroberts merged commit 4d8908d into huggingface:main Sep 19, 2024
13 checks passed
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
@faaany faaany deleted the enable_on_xpu branch February 7, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants