Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] skip tests for xpu #33553

Merged
merged 8 commits into from
Sep 19, 2024
Merged

[tests] skip tests for xpu #33553

merged 8 commits into from
Sep 19, 2024

Conversation

faaany
Copy link
Contributor

@faaany faaany commented Sep 18, 2024

What does this PR do?

This PR skips some tests for xpu, as xpu doesn't have that feature yet.

@faaany
Copy link
Contributor Author

faaany commented Sep 19, 2024

@amyeroberts

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

In the future we might want something more general for other accelerators s.t. we can pass in e.g. a list to configure the decorator instead of having to have one per hardware

cc @ydshieh for reference

@amyeroberts amyeroberts merged commit b87755a into huggingface:main Sep 19, 2024
20 checks passed
@ydshieh
Copy link
Collaborator

ydshieh commented Sep 20, 2024

In the future we might want something more general for other accelerators s.t. we can pass in e.g. a list to configure the decorator instead of having to have one per hardware

Good pint!

@faaany I am a bit confused by the changes like

    @require_non_xpu
    @require_torch_gpu

Previously, it was already has @require_torch_gpu, how were that/those tests be triggered on a xpu device ...?

@faaany
Copy link
Contributor Author

faaany commented Sep 20, 2024

Hi @ydshieh , this test will not run on XPU. But we end up with this test require torch gpu as skip message, but we are not sure whether this could run on xpu or not. So require_non_xpu will be more specific, so that we know that this test is skipped because xpu doesn't have that feature yet.

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 20, 2024

Ah yeah, good point! Thanks for explaining.

BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* enable

* fix

* add xpu skip

* add marker

* skip for xpu

* add more

* add one more
@faaany faaany deleted the skip_xpu branch February 7, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants