Add revision to trainer push_to_hub

[teamclouday]

What does this PR do?

Add revision to trainer's push_to_hub method. See #33481

Before submitting

• This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
• Did you read the contributor guideline,
  Pull Request section?
• Was this discussed/approved via a Github issue or the forum? Please add a link
  to it if that's the case.
• Did you make sure to update the documentation with your changes? Here are the
  documentation guidelines, and
  here are tips on formatting docstrings.
• Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

[not-lain]

Thanks for adding this

[teamclouday]

Thank you for the suggestions! Just made a new commit

[not-lain]

perfect, the failing tests are unrelated to this PR.
cc @SunMarc for review

[SunMarc]

Thanks for adding this @teamclouday ! Did you test the PR ?

[teamclouday]

Thanks for adding this @teamclouday ! Did you test the PR ?

I just added test code! Can run it with:

export HUGGINGFACE_CO_STAGING=1; python -m unittest -v tests.trainer.test_trainer.TrainerIntegrationWithHubTester.test_push_to_hub_with_revision

Currently with revision, the code is assuming that branch already exists. Wonder if it's necessary to automatically create new branch if not found.

[not-lain]

Don't forget to format your files with ruff

[teamclouday]

Don't forget to format your files with ruff

Thanks for reminder! Just applied the format

[not-lain]

the setup_and_quality tests are still failing
This can be fixed by organizing the imports and you should be all good.

[teamclouday]

Just fixed the imports! Should be good now. Sorry about the back and forth

[amyeroberts]

Isn't it the branch to commit to - rather than the commit to commit from?

[teamclouday]

I think this description comes from the hub upload_folder api. I was only going to use it for branches and tested with that, so not sure if it works for other commit hashes.

[amyeroberts]

OK!

[amyeroberts]

Thanks for adding!

[SunMarc]

Can you rebase on main to make the CI green @teamclouday ?

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[teamclouday]

I just rebased to main and CI is green now! Thank you all!