Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n-ur] Added README_ur.md file #33461

Merged
merged 2 commits into from
Sep 18, 2024
Merged

[i18n-ur] Added README_ur.md file #33461

merged 2 commits into from
Sep 18, 2024

Conversation

akkefa
Copy link
Contributor

@akkefa akkefa commented Sep 13, 2024

What does this PR do?

Translate docs into Urdu language issue #33139

Documentation:
@stevhliu @LysandreJik

@akkefa
Copy link
Contributor Author

akkefa commented Sep 13, 2024

@stevhliu I’ve created a new pull request and hope to avoid any CircleCI errors this time.

@stevhliu
Copy link
Member

@LysandreJik or @ydshieh, would you happen to know why the other two tests aren't being run?

@LysandreJik
Copy link
Member

Given the changes only affect docs, I believe we can safely ignore the circle ci docs @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@akkefa
Copy link
Contributor Author

akkefa commented Sep 17, 2024

@stevhliu Who will merge the pull request ?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu
Copy link
Member

Given the changes only affect docs, I believe we can safely ignore the circle ci docs

Unfortunately, I can't merge it because the required tests aren't passing @LysandreJik :(

@LysandreJik LysandreJik merged commit 5427eaa into huggingface:main Sep 18, 2024
1 of 5 checks passed
@LysandreJik
Copy link
Member

Merged 🚀

@ydshieh
Copy link
Collaborator

ydshieh commented Sep 18, 2024

For the recorder

The CI is running under akkefa personal account. Please follow https://support.circleci.com/hc/en-us/articles/360008097173-Troubleshooting-why-pull-requests-are-not-triggering-jobs-on-my-organization- to fix it.

If you're following the fork instead of the upstream repo

A user who submits a pull request to your repository from a fork, but no pipeline is triggered with the pull request. This can happen when the user is following the project fork on their personal account rather than the project itself on CircleCI.

This will cause the jobs to trigger under the user's personal account. If the user is following a fork of the repository on CircleCI, we will only build on that fork and not the parent, so the parent’s PR will not get status updates.

In these cases, the user unfollows their fork of the project on CircleCI. This will trigger their jobs to run under the organization when they submit pull requests. Those users can optionally follow the source project if they wish to see the pipelines.

@akkefa akkefa deleted the urdu_docs branch September 18, 2024 17:32
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
* Urdu docs added

* fixed the misaligned issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants