Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated task in load_dataset #33433

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Remove deprecated task in load_dataset #33433

merged 1 commit into from
Sep 11, 2024

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Sep 11, 2024

What does this PR do?

Remove deprecated task in load_dataset from tensorflow example. This parameter was deprecated in datasets-2.14.0 one year ago:

Once datasets-3.0 is released, it will raise an error and transformers CI will break.

Fixes #33432

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LysandreJik LysandreJik merged commit 42babe8 into main Sep 11, 2024
9 of 10 checks passed
@LysandreJik LysandreJik deleted the fix-33432 branch September 11, 2024 12:18
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage of deprecated task will break CI after datasets-3.0
4 participants