Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WhisperTokenizer Doc: Timestamps and Previous Tokens Behaviour #33390

Merged

Conversation

bruno-hays
Copy link
Contributor

What does this PR do?

#32378

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ylacombe

Copy link
Contributor

@ylacombe ylacombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clear! Thanks for taking care of this!

For the CI tests to pass, you should also:

  1. rebase the branch
  2. apply your modification to the fast whisper tokenizer (you can simply do make fix-copies)
  3. reformate for quality. To do and as per the contributing guide, you only have to install the right dependencies (pip install -e ".[quality]") and to apply style correction (make fixup)

@bruno-hays
Copy link
Contributor Author

bruno-hays commented Sep 9, 2024

Thanks @ylacombe !
I ran into some issues running make fixup due to it needing both torch and tensorflow.
But I get this before it crashes:

Checking/fixing src/transformers/models/whisper/tokenization_whisper.py src/transformers/models/whisper/tokenization_whisper_fast.py
All checks passed!
2 files left unchanged
python utils/custom_init_isort.py
python utils/sort_auto_mappings.py
python utils/check_doc_toc.py --fix_and_overwrite
running deps_table_update
updating src/transformers/dependency_versions_table.py
python utils/check_copies.py
python utils/check_table.py
python utils/check_dummies.py
python utils/check_repo.py

I hope it means it's ok, no file changed

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LysandreJik LysandreJik merged commit dfee4f2 into huggingface:main Sep 10, 2024
8 checks passed
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…huggingface#33390)

* added doc explaining behaviour regarding tokens timestamps and previous tokens

* copied changes to faster tokenizer

---------

Co-authored-by: Bruno Hays <bruno.hays@illuin.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants