use diff internal model in tests #33387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Hi! Could you briefly explain what are the other changes for (except that of changing the repo id.)? (for example, those are necessary changes for #31316, or it's for something else?) |
ydshieh
approved these changes
Sep 10, 2024
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* use diff internal model in tests * use diff internal model in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to use internal model - @require_read_token only works for internal
other changes:
bos_tokenandeos_tokenbecause renaming the internal repo to "llama-3" from "llama3" resulted in the AutoTokenizer instantiating with LlamaTokenizerFast as opposed to PreTrainedTokenizerFast. This is good but needs to havebos_tokenandeos_tokenupdated to theLlama-3values instead of the default<s>and</s>cc @ydshieh(related to tiktoken support PR Support reading tiktoken tokenizer.model file #31656)
@ArthurZucker