Bug Fix: Update hub.py to fix NoneType error #33315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: TypeError: argument of type 'NoneType' is not iterable Analysis: The error `TypeError: argument of type 'NoneType' is not iterable` suggests that `model_card.data.tags` is `None`, and the code is trying to iterate through it using `not in`. Fix: 1. **Check if `model_card.data.tags` is `None` before the loop**: Since you're checking the variable `tags` before the loop, you should also ensure that `model_card.data.tags` is not `None`. You can do this by initializing `model_card.data.tags` to an empty list if it's `None`. 2. **Updated code**: Add a check and initialize the `tags` if it is `None` before proceeding with the iteration. This way, if `model_card.data.tags` is `None`, it gets converted to an empty list before checking the contents. This prevents the `TypeError`.
|
Thanks for the PR! Could you just run the code quality tool to ensure that the code quality passes? You can install them with the following, from the root of your clone: And then run them with: |
merge hf main
|
@LysandreJik done, it's passing now. Blank line had to be removed. |
|
Awesome, thanks! |
LysandreJik
approved these changes
Sep 10, 2024
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* Bug Fix: Update hub.py Bug: TypeError: argument of type 'NoneType' is not iterable Analysis: The error `TypeError: argument of type 'NoneType' is not iterable` suggests that `model_card.data.tags` is `None`, and the code is trying to iterate through it using `not in`. Fix: 1. **Check if `model_card.data.tags` is `None` before the loop**: Since you're checking the variable `tags` before the loop, you should also ensure that `model_card.data.tags` is not `None`. You can do this by initializing `model_card.data.tags` to an empty list if it's `None`. 2. **Updated code**: Add a check and initialize the `tags` if it is `None` before proceeding with the iteration. This way, if `model_card.data.tags` is `None`, it gets converted to an empty list before checking the contents. This prevents the `TypeError`. * Update hub.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
TypeError: argument of type 'NoneType' is not iterable
Analysis:
The error
TypeError: argument of type 'NoneType' is not iterablesuggests thatmodel_card.data.tagsisNone, and the code is trying to iterate through it usingnot in.Fix:
Check if
model_card.data.tagsisNonebefore the loop: Since you're checking the variabletagsbefore the loop, you should also ensure thatmodel_card.data.tagsis notNone. You can do this by initializingmodel_card.data.tagsto an empty list if it'sNone.Updated code: Add a check and initialize the
tagsif it isNonebefore proceeding with the iteration.This way, if
model_card.data.tagsisNone, it gets converted to an empty list before checking the contents. This prevents theTypeError.