Fix: use torch.from_numpy() to create tensors for np.ndarrays
#33201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qubvel
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
@shinyano Thanks for fixing this! Looks good overall!
The only potential danger is that from_numpy shares the same storage as the original NumPy array, whereas torch.tensor copies the data. If someone modifies the original array in place, the tensor will also be modified, and vice versa.
However, I'm not sure that will be a real problem.
@amyeroberts for final review
amyeroberts
approved these changes
Sep 2, 2024
| @@ -579,9 +579,15 @@ def normalize(self, image, mean, std, rescale=False): | |||
| import torch | |||
|
|
|||
| if not isinstance(mean, torch.Tensor): | |||
| mean = torch.tensor(mean) | |||
There was a problem hiding this comment.
as a general note: this class isn't used anymore so changing this won't have any effect. Let's keep though to be consistent with the other mixins
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…ingface#33201) use torch.from_numpy for np.ndarrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #33185 by using
torch.from_numpy()to create tensors for np.ndarrays, instead oftorch.tensor()which may cause hanging.I did some rough search in the code and made changes where I thought necessary. Code using
tensor()withdtypespecified remains unchanged to prevent potential type errors.Also,
torch.from_numpy()would share memory with numpy array, whiletorch.tensor()copies data. If this change would cause potential problems, please let me know.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@qubvel Thanks for your review!