Remove repeated prepare_images in processor tests #33163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
e30eac4 to
e32830c
Compare
4e86402 to
e54c6bf
Compare
zucchini-nlp
approved these changes
Sep 9, 2024
Comment on lines
+60
to
+61
| """This function prepares a list of PIL images.""" | ||
| return prepare_image_inputs() |
There was a problem hiding this comment.
I guess this is similar to mgp-str where we can't use ProcessorTesterMixin, a comment explaining that would be nice
There was a problem hiding this comment.
I've added comments - LMK if they're OK
amyeroberts
commented
Sep 9, 2024
| @@ -44,6 +44,13 @@ | |||
| from transformers import CLIPImageProcessor | |||
|
|
|||
|
|
|||
| def prepare_image_inputs(): | |||
There was a problem hiding this comment.
Move out as a function s.t. processing classes which can't use ProcessorTesterMixin in their test module can still import and re-use this logic instead of reimplementing
LysandreJik
approved these changes
Sep 9, 2024
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* Remove repeated prepare_images * Address comments - update docstring; explanatory comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title - moves the logic to the processor tester mixin and its module