Generate: throw warning when return_dict_in_generate is False but should be True
#33146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
commented
Aug 27, 2024
| @@ -786,7 +798,8 @@ def save_pretrained( | |||
|
|
|||
| if use_auth_token is not None: | |||
| warnings.warn( | |||
| "The `use_auth_token` argument is deprecated and will be removed in v5 of Transformers. Please use `token` instead.", | |||
| "The `use_auth_token` argument is deprecated and will be removed in v5 of Transformers. " | |||
ArthurZucker
approved these changes
Aug 27, 2024
Comment on lines
735
to
740
| if getattr(self, extra_output_flag) is True: | ||
| warnings.warn( | ||
| f"`return_dict_in_generate` is NOT set to `True`, but `{extra_output_flag}` is. When " | ||
| f"`return_dict_in_generate` is not `True`, `{extra_output_flag}` will not be respected.", | ||
| UserWarning, | ||
| ) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
Aug 28, 2024
f93cf14 to
fce676b
Compare
…set in the model config
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title.
I've fallen victim to this one a few times, so it probably means users have fallen too :)