-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update push CI workflow files for security #33142
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling!
@@ -76,11 +81,7 @@ jobs: | |||
# `CI_SHA_WORKFLOW_RUN`: The commit SHA that triggers this workflow by `workflow_run` event | |||
# `CI_SHA`: The non-empty commit SHA from the above two (one and only one of them is empty) | |||
run: | | |||
CI_BRANCH_PUSH=${{ github.event.ref }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move the corresponding comments about the different CI values to the new place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will do before merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SG!
* update for security 1 * update for security 2 * update for security 3 * update for security 4 * update for security 5 --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?
See internal discussion