Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed pydantic required version in dockerfiles to make it compatible with DeepSpeed #33105

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

What does this PR do?

The DeepSpeed module now requires pydantic vesrion >=2.0.0.
https://github.com/microsoft/DeepSpeed/blob/e2654bfd1ab431bde088a7501ed01b503daa5ab1/requirements/requirements.txt#L6

This is why the following docker builds are failing
https://github.com/huggingface/transformers/actions/runs/10534132397/job/29191315906#
https://github.com/huggingface/transformers/actions/runs/10534132397/job/29191315906

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ydshieh @amyeroberts

@ydshieh ydshieh self-assigned this Aug 26, 2024
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@muellerzr We will have to check if pydantic will cause some new failures afterwards. (And to check if the docker images could be even build - but I can check this part)

@ydshieh ydshieh requested a review from muellerzr August 26, 2024 14:01
@muellerzr
Copy link
Contributor

Joy okay, sounds good. Thanks for the flag.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh ydshieh merged commit 3562772 into huggingface:main Aug 26, 2024
8 checks passed
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
…atible with DeepSpeed (huggingface#33105)

Fixed pydantic required version in dockerfiles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants