-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing test with race condition #32140
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Ready for review @amyeroberts! In case you're worried about the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling @Rocketknight1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally!
Thank you. I didn't touch anything about Anyway, I will rework this kind of thing in #32025 |
The
test_push_to_hub_dynamic_processor
callscreate_repo
with a fixed repo name, and often throws an error in the CI. I suspect this happens when multiple test runners try to create the repo at the same time.I rewrote the test to use a randomized repo name, which should hopefully avoid these collisions - though I don't know how the dummy user works, so I hope these still get cleaned up!