Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test with race condition #32140

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Conversation

Rocketknight1
Copy link
Member

The test_push_to_hub_dynamic_processor calls create_repo with a fixed repo name, and often throws an error in the CI. I suspect this happens when multiple test runners try to create the repo at the same time.

I rewrote the test to use a randomized repo name, which should hopefully avoid these collisions - though I don't know how the dummy user works, so I hope these still get cleaned up!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Rocketknight1
Copy link
Member Author

Ready for review @amyeroberts! In case you're worried about the try/finally thing, or clogging up the dummy user, see this discussion.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling @Rocketknight1

c.f. #31973 #32025 cc @ydshieh

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

@Rocketknight1 Rocketknight1 merged commit 7ba028f into main Jul 22, 2024
22 checks passed
@Rocketknight1 Rocketknight1 deleted the fix_overlapping_tests branch July 22, 2024 15:07
@ydshieh
Copy link
Collaborator

ydshieh commented Jul 24, 2024

Thanks for handling @Rocketknight1

c.f. #31973 #32025 cc @ydshieh

Thank you. I didn't touch anything about test_processor_auto and didn't add any new create_repo. But yes, probably I forgot to use finally.

Anyway, I will rework this kind of thing in #32025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants