Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed raising TypeError instead of ValueError for invalid type #32111

Merged
merged 6 commits into from
Jul 22, 2024
Merged

fix: Fixed raising TypeError instead of ValueError for invalid type #32111

merged 6 commits into from
Jul 22, 2024

Conversation

Sai-Suraj-27
Copy link
Contributor

What does this PR do?

At few places in the code-base we are checking the type of something but raising ValueError instead of TypeError. I used ruff to find these.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts

amyeroberts
amyeroberts approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts
Copy link
Collaborator

@Sai-Suraj-27 Could you rebase on main? This should fix the hub tests

@Sai-Suraj-27
Copy link
Contributor Author

@Sai-Suraj-27 Could you rebase on main? This should fix the hub tests

Done 👍🏻

@amyeroberts amyeroberts merged commit 12b6880 into huggingface:main Jul 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sai-Suraj-27 @amyeroberts