Fix tests after huggingface_hub 0.24
#32054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
reviewed
Jul 18, 2024
| self.assertIn(f"Training in progress, step {i}", commits) | ||
| nb_expected_commits = len(range(5, max_steps, 5)) | ||
|
|
||
| self.assertGreaterEqual(nb_empty_commits + nb_epoch_commits, nb_expected_commits) |
There was a problem hiding this comment.
Could you leave a short comment why is it >=?
There was a problem hiding this comment.
addressed in ff09978
ydshieh
approved these changes
Jul 18, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Let me check the version |
|
It is |
Yes I think we need to wait for tomorrow (building docker image once a day right?) |
|
yes! although we can build manually but it's a bit more involved |
amyeroberts
approved these changes
Jul 18, 2024
|
I like bonus points 😍 (though it was thanks to @ydshieh's request 😄) |
|
I am a lazy programmer so I ask a lot of clear comments 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion on slack (private).
In latest
huggingface_hubupdate (0.24.0!), some logic has been added to avoid empty commits. This mechanism should prevent bloating git history when no changes have been detected. This change broke 2 tests intransformers's CI which should be fixed by this PR (previously tested on main...ci-test-huggingface-hub-v0.24.0.rc0). Note: when an empty commit is prevented, a warning message is logged to the user. This is what we are testing in this PR.cc @ydshieh with whom we discussed this
EDIT: tests are failing since CI is still running on
huggingface_hub==0.23.5. I guess rerunning them tomorrow should be good?