Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RoBERTa] Minor clarifications to model doc #31949

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

bt2513
Copy link
Contributor

@bt2513 bt2513 commented Jul 13, 2024

What does this PR do?

Hi there! When looking into the RoBERTa documentation, I noticed that some words were missing in the second point of the pre-training tricks (in addition to a typo "than" vs "that"). I thought it might be helpful to fix this and proposed minor suggestions to correct and clarify the documentation

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu @MKhalusova @sgugger

@bt2513
Copy link
Contributor Author

bt2513 commented Jul 20, 2024

Hi @stevhliu @MKhalusova @sgugger - I just wanted to follow up with this and get your thoughts on this PR. Should someone else be involved? Please let me know, thanks :)

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying! 🤗

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@stevhliu stevhliu merged commit 7987710 into huggingface:main Jul 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants