Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mask creations of GPTNeoX and GPT2 #31944

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

vasqu
Copy link
Contributor

@vasqu vasqu commented Jul 13, 2024

What does this PR do?

Fixes #31943

SDPA implementations done by me have introduced a careless mistake in the mask creation, e.g. SDPA has to create a mask even when the attention mask is None, for example when cached input is passed as demonstrated in the issue mentioned above.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker @amyeroberts

@vasqu
Copy link
Contributor Author

vasqu commented Jul 13, 2024

The timeouts are back 😢

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Can you add what was reported as an issue to the tests? 🤗

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@vasqu
Copy link
Contributor Author

vasqu commented Jul 16, 2024

@ArthurZucker I've added the tests to GPTNeoX and GPT2. Not sure if the reference to the issue is a good idea or not, just went with it.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating, indeed the order makes sense as for full attention you gotta create the mask even if None

@ArthurZucker ArthurZucker merged commit 605f324 into huggingface:main Jul 23, 2024
22 checks passed
@vasqu vasqu deleted the fix-sdpa-mask-creation branch July 23, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very different output depending on whether an attention mask is passed when using caching
3 participants