Push sharded checkpoint to hub when push_to_hub=True
in TrainingArguments
#31808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR make sure that sharded checkpoints are pushed to the hub when we set
push_to_hub=True
inTrainingArguments
.Fixes #30724.
Thanks @alvarobartt for the detailed issue !
I didn't add a test as it requires a big model to test it and we can't change the shard size when saving from Trainer.
To reproduce:
I was able to successfully push the checkpoints here : https://huggingface.co/marcsun13/sft_openassistant-guanaco/tree/main