Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify new docker images built for circleci #31701

Merged
merged 10 commits into from
Jul 15, 2024
Merged

Notify new docker images built for circleci #31701

merged 10 commits into from
Jul 15, 2024

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Jun 28, 2024

What does this PR do?

Notify new docker images built for circleci

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot thanks! We could also send a message for dev ci images that are built

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

I'd maybe post in a different channel to avoid spamming but otherwise looks great ❤️

@ydshieh ydshieh force-pushed the notify_new_image branch from 3b3551e to b790e10 Compare July 15, 2024 13:34
@ydshieh
Copy link
Collaborator Author

ydshieh commented Jul 15, 2024

@amyeroberts I change to a new channel #transformers-ci-circleci-images as suggested
@ArthurZucker Our original goal is to avoid surprise of new images pushed and used by everyone while we are not aware of it.

I will merge this PR as it is. If in the future we see the real need of notifying of dev ci images too, we can iterate.

@ydshieh ydshieh merged commit 11efb4f into main Jul 15, 2024
9 checks passed
@ydshieh ydshieh deleted the notify_new_image branch July 15, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants