Add valid columns check in _remove_unused_columns method #31466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerzr
reviewed
Jun 18, 2024
Comment on lines
150
to
151
| overall_loss = torch.sum(tokens_per_expert * router_prob_per_expert.unsqueeze(0)) | ||
| return overall_loss * num_experts | ||
| # Ensure the loss calculation balances each expert's load correctly | ||
| overall_loss = torch.sum(tokens_per_expert * router_prob_per_expert) |
There was a problem hiding this comment.
These seem like unrelated changes, no?
There was a problem hiding this comment.
Oh ,sorry for that
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@muellerzr many thanks! |
|
@amyeroberts would you please merge this PR? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add valid columns check in _remove_unused_columns method to fix
huggingface/datasets#6973
huggingface/datasets#6535
This improvement helps users to quickly identify and resolve issues related to column matching between the dataset and the model's forward method.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.