Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing errors in Qwen2ForTokenClassification #31440

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Jun 15, 2024

No description provided.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts
Copy link
Collaborator

@kevinhu Running make fix-copies and pushing the changes should resolve the CI failures

@kevinhu
Copy link
Contributor Author

kevinhu commented Jun 18, 2024

@amyeroberts Thanks for the tip, however running make fix-copies had the opposite effect of removing the proposed changes to Qwen2 rather than propagating them to the other files.

I've gone ahead and updated them so the tests pass now.

@amyeroberts amyeroberts merged commit 1f9387d into huggingface:main Jun 18, 2024
19 checks passed
@kevinhu kevinhu deleted the patch-1 branch June 24, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants