-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CometCallback to allow reusing of the running experiment #31366
Conversation
Hi @Lothiraldan, thanks for opening a PR! Let us know when it's ready for review. cc @muellerzr |
Hi @amyeroberts, I wanted to open a PR in our fork for internal review first. Sorry about the noise. I can close this one, reopen one in our fork or leave this one open and have the comments shared internally, let me know what would works best for you. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@Lothiraldan Any of the options work for us. We can leave this open until your internal review has happened, this PR has been updated to reflect the review and then you can just ping us when it's ready :) |
Also simplify how the Comet Experiment name is passed
@amyeroberts Hi, this PR is now ready for a review. Sorry for the delay, the internal reviews highlighted some potential improvements that took a bit of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me. cc @amyeroberts for final review? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean handling of the versioning. LGTM!
What does this PR do?
Update CometCallback to allow reusing of the running experiment.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.