Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest of model init refactors #31330

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Rest of model init refactors #31330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5962d6f
Import structure & first three model refactors
LysandreJik Jun 8, 2024
af3b225
Register -> Export. Export all in __all__. Sensible defaults accordin…
LysandreJik Jul 25, 2024
5a293ea
Apply most comments from Amy and some comments from Lucain
LysandreJik Jul 25, 2024
1f528f9
Style
LysandreJik Jul 25, 2024
226c8ec
Add comment
LysandreJik Jul 25, 2024
2a727f6
Clearer .py management
LysandreJik Jul 25, 2024
818b572
Raise if not in backend mapping
LysandreJik Jul 26, 2024
c07e817
More specific type
LysandreJik Jul 26, 2024
f92d17c
More efficient listdir
LysandreJik Jul 26, 2024
3967eaa
Misc fixes
LysandreJik Sep 6, 2024
e3665de
Rest of the model refactors
LysandreJik Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ jobs:
command: pip freeze | tee installed.txt
- store_artifacts:
path: ~/transformers/installed.txt
- run: python -c "from transformers import *" || (echo '🚨 import failed, this means you introduced unprotected imports! 🚨'; exit 1)
- run: python -c "from transformers import *" || (echo '🚨 import failed, this means you introduced unprotected imports! Have you added this object to the __all__ object of the module? 🚨'; exit 1)
- run: ruff check examples tests src utils
- run: ruff format tests src utils --check
- run: python utils/custom_init_isort.py --check_only
Expand Down
4 changes: 1 addition & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,9 @@ repo-consistency:
# this target runs checks on all files

quality:
@python -c "from transformers import *" || (echo '🚨 import failed, this means you introduced unprotected imports! 🚨'; exit 1)
@python -c "from transformers import *" || (echo '🚨 import failed, this means you introduced unprotected imports! Have you added this object to the __all__ object of the module? 🚨'; exit 1)
ruff check $(check_dirs) setup.py conftest.py
ruff format --check $(check_dirs) setup.py conftest.py
python utils/custom_init_isort.py --check_only
python utils/sort_auto_mappings.py --check_only
python utils/check_doc_toc.py
python utils/check_docstrings.py --check_all
Expand All @@ -62,7 +61,6 @@ quality:
# Format source code automatically and check is there are any problems left that need manual fixing

extra_style_checks:
python utils/custom_init_isort.py
python utils/sort_auto_mappings.py
python utils/check_doc_toc.py --fix_and_overwrite

Expand Down
Loading
Loading