Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new line switch before logging ***** Running {description} ***** #31225

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

jacklanda
Copy link
Contributor

What does this PR do?

Nothing too big, I found the logging info does not switch to the new line. It is a tiny optimization on outlooking in the command line interface.

Before this change:
图片

After adding "\n", the same printing looks like the following.
图片

Fixes # (issue)
The output logging information "***** Running {description} *****" doesn't start from the new line.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@muellerzr @SunMarc

…**".

Signed-off-by: jacklanda <yonyonlau@gmail.com>
@jacklanda
Copy link
Contributor Author

jacklanda commented Jun 4, 2024

Please re-run the test ci for me.

Thank you!

图片

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! CircleCI is having some terrible times today, but this PR looks good to me. cc @amyeroberts we can merge this :)

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@amyeroberts amyeroberts merged commit 821b772 into huggingface:main Jun 4, 2024
4 of 6 checks passed
@jacklanda jacklanda deleted the logging-info-newline branch June 4, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants